11063 1 true 2009-06-23T09:08:53-04:00 40820 14 component-without-recurrence-properties-should-enumerate-just-itself-only-if-it-is-within-the-period-between-starting-and-before 118641 30941 resolved before empty non occurrences recurring rrule starting 2009-07-06T16:31:43-04:00 40820 Klaas Jan Wierenga Klaas Jan Wierenga Rick DeNatale http://rick_denatale.lighthouseapp.com/projects/30941/tickets/14 I wrote the attached failing spec to show what the problem is (expected 0 got 1) * Single event without recurrence. Date is before :starting date. event.occurrences still returns a single occurrence (with a date before :starting). This is unexpected. I think OccurrenceEnumerator::EmptyRulesEnumerator should be modified to handle this case, but I don't known how. ----- $ git diff diff --git a/spec/ri_cal/occurrence_enumerator_spec.rb b/spec/ri_cal/occurrence_enumerator_spec.rb diff --git a/spec/ri_cal/occurrence_enumerator_spec.rb b/spec/ri_cal/occurrence_enumerator_spec.rb index cb5ddcf..af68a50 100644 --- a/spec/ri_cal/occurrence_enumerator_spec.rb +++ b/spec/ri_cal/occurrence_enumerator_spec.rb @@ -70,6 +70,19 @@ TEXT result.map{|o|o.dtstart}.should == Fr13UnboundedZuluExpectedFive[0..2].map{|e| e.dtstart} end end + + describe "for a non-recurring event with :starting and :before specified" do + it "should exclude dates before :starting and after :before" do + first = Time.now + (3600*24*31) # 31 days from now + last = first + (3600*24*31) # 31 days later + event = RiCal.Event do |event| + event.dtstart = Time.now.utc + event.dtend = Time.now.utc + 3600 + # event.rrule (no recurrence, single event) + end + event.occurrences(:starting => first, :before => last).size.should eql(0) + end + end end end I wrote the attached failing spec to show what the problem is (expected 0 got 1) * Single event without recurrence. Date is before :starting date. event.occurrences still returns a single occurrence (with a date before :starting). This is unexpected. I think OccurrenceEnumerator::EmptyRulesEnumerator should be modified to handle this case, but I don't known how. ----- $ git diff diff --git a/spec/ri_cal/occurrence_enumerator_spec.rb b/spec/ri_cal/occurrence_enumerator_spec.rb diff --git a/spec/ri_cal/occurrence_enumerator_spec.rb b/spec/ri_cal/occurrence_enumerator_spec.rb index cb5ddcf..af68a50 100644 --- a/spec/ri_cal/occurrence_enumerator_spec.rb +++ b/spec/ri_cal/occurrence_enumerator_spec.rb @@ -70,6 +70,19 @@ TEXT result.map{|o|o.dtstart}.should == Fr13UnboundedZuluExpectedFive[0..2].map{|e| e.dtstart} end end + + describe "for a non-recurring event with :starting and :before specified" do + it "should exclude dates before :starting and after :before" do + first = Time.now + (3600*24*31) # 31 days from now + last = first + (3600*24*31) # 31 days later + event = RiCal.Event do |event| + event.dtstart = Time.now.utc + event.dtend = Time.now.utc + 3600 + # event.rrule (no recurrence, single event) + end + event.occurrences(:starting => first, :before => last).size.should eql(0) + end + end end end <div><p>I wrote the attached failing spec to show what the problem is (expected 0 got 1)</p> <ul> <li>Single event without recurrence. Date is before :starting date. event.occurrences still returns a single occurrence (with a date before :starting). This is unexpected. I think OccurrenceEnumerator::EmptyRulesEnumerator should be modified to handle this case, but I don't known how.</li> </ul> <hr> <p>$ git diff diff --git a/spec/ri_cal/occurrence_enumerator_spec.rb b/spec/ri_cal/occurrence_enumerator_spec.rb diff --git a/spec/ri_cal/occurrence_enumerator_spec.rb b/spec/ri_cal/occurrence_enumerator_spec.rb index cb5ddcf..af68a50 100644 --- a/spec/ri_cal/occurrence_enumerator_spec.rb +++ b/spec/ri_cal/occurrence_enumerator_spec.rb @@ -70,6 +70,19 @@ TEXT</p> <pre> <code> result.map{|o|o.dtstart}.should == Fr13UnboundedZuluExpectedFive[0..2].map{|e| e.dtstart} end end </code> </pre> <ul> <li>describe "for a non-recurring event with :starting and :before specified" do</li> <li> <pre> <code> it "should exclude dates before :starting and after :before" do </code> </pre></li> <li> <pre> <code> first = Time.now + (3600*24*31) # 31 days from now </code> </pre></li> <li> <pre> <code> last = first + (3600*24*31) # 31 days later </code> </pre></li> <li> <pre> <code> event = RiCal.Event do |event| </code> </pre></li> <li> <pre> <code> event.dtstart = Time.now.utc </code> </pre></li> <li> <pre> <code> event.dtend = Time.now.utc + 3600 </code> </pre></li> <li> <pre> <code> # event.rrule (no recurrence, single event) </code> </pre></li> <li> <pre> <code> end </code> </pre></li> <li> <pre> <code> event.occurrences(:starting =&gt; first, :before =&gt; last).size.should eql(0) </code> </pre></li> <li> <pre> <code> end </code> </pre></li> <li>end end end</li> </ul></div> 11063 0 I wrote the attached failing spec to show what the problem is (expected 0 got 1) Given a single event without recurrence (no rrule set). Date is before :starting date. event.occurrences still returns a single occurrence (with a date before :starting). This is unexpected. I think OccurrenceEnumerator::EmptyRulesEnumerator should be modified to handle this case, but I don't known how. <div><p>I wrote the attached failing spec to show what the problem is (expected 0 got 1)</p> <p>Given a single event without recurrence (no rrule set). Date is before :starting date. event.occurrences still returns a single occurrence (with a date before :starting). This is unexpected. I think OccurrenceEnumerator::EmptyRulesEnumerator should be modified to handle this case, but I don't known how.</p></div> false 2009-06-23T09:08:53-04:00 40820 --- {} 14 component-without-recurrence-properties-should-enumerate-just-itself-only-if-it-is-within-the-period-between-starting-and-before 0 30941 new before empty non occurrences recurring rrule starting 2009-06-23T09:11:05-04:00 40820 Klaas Jan Wierenga Klaas Jan Wierenga Rick DeNatale http://rick_denatale.lighthouseapp.com/projects/30941/tickets/14 11063 1 Forgot to close this. Fix was in 0.7.0 <div><p>Forgot to close this. Fix was in 0.7.0</p></div> true 2009-07-06T12:08:36-04:00 40820 --- :state: new 14 component-without-recurrence-properties-should-enumerate-just-itself-only-if-it-is-within-the-period-between-starting-and-before 0 30941 resolved before empty non occurrences recurring rrule starting 2009-07-06T12:08:39-04:00 11063 Rick DeNatale Klaas Jan Wierenga Rick DeNatale http://rick_denatale.lighthouseapp.com/projects/30941/tickets/14 11063 1 excellent, thank you <div><p>excellent, thank you</p></div> true 2009-07-06T16:31:43-04:00 40820 --- {} 14 component-without-recurrence-properties-should-enumerate-just-itself-only-if-it-is-within-the-period-between-starting-and-before 0 30941 resolved before empty non occurrences recurring rrule starting 2009-07-06T16:31:43-04:00 40820 Klaas Jan Wierenga Klaas Jan Wierenga Rick DeNatale http://rick_denatale.lighthouseapp.com/projects/30941/tickets/14 a575e48f07a0636d4b180f7a0c861f7a17619207 text/plain 2009-06-23T09:08:54-04:00 occurrence_enumerator_spec.rb.patch 136536 990 40820 http://rick_denatale.lighthouseapp.com/attachments/136536/occurrence_enumerator_spec.rb.patch